test: retry transient GitHub API errors in scenario suite#147
Merged
Conversation
Signed-off-by: Joshua Temple <[email protected]>
Contributor
Cascade plan previewThis merge would:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under the concurrent 10-repo fleet fan-out, individual gh calls intermittently hit transient GitHub API errors (observed: HTTP 401 and HTTP 500 on workflow dispatch), failing the run on a different repo each time. Add a gh() wrapper sourced via BASH_ENV that retries only transient HTTP 401/403/429/5xx (and secondary-rate-limit markers) with bounded backoff, and passes every other result through unchanged. It returns immediately on exit 0, so a gh call that succeeds and reports a logical failure conclusion (what the negative probes assert) is never retried; real 404/422 errors propagate. Five attempts, fails closed. actionlint clean; masking-safety proven by bash unit tests (logical failures and 404/422 pass through, only transient HTTP errors retry).